+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34738/24388

• This PR adds an extra 24KB to repository

A new Pull Request was created by @bsunanda (Sunanda Banerjee) for master.

It involves the following packages:

• SimG4CMS/Calo (simulation)

@cmsbuild, @civanch, @mdhildreth can you please review it and eventually sign? Thanks.
@cvuosalo, @rovere, @thomreis, @felicepantaleo, @simonepigazzini, @fabiocos, @slomeo this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy, @perrotta you are the release manager for this.

cms-bot commands are listed here

@cmsbuild Please test

type bugfix

@bsunanda thank you for the fix.
I'm running my usual test, will be ready soon.
Some DQM files (from the total test bunch) start coming out of the Condor.
I can see that their size corresponds to the "nominal" (e.g. 12_0_0_pre4) one.

@civanch and @bsunanda
I guess, once successfully tested, it needs to be backported to 12_0_X?

Pion gun "CaloScan" test of
(i) CMSSW_12_1_X_2021-08-02-2300 + this PR
vs
(ii) CMSSW_12_0_0_pre4
shows good agreement for SimHits sums (within stat.errors) in the barrel/endcaps.
NB: HF change comes (as expected) from old SL -> new SL change (in 12_0_0_pre5).

http://cern.ch/go/m7qD

@bsunanda , thanks for this critical fix and @abdoulline , thank for the prompt analysis.

This PR should be backported to 12_0_X. 12_0_0_pre5 is broken and this fix recover HCAL hits.

-1

Failed Tests: RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a561c0/17450/summary.html
COMMIT: 6bb255f
CMSSW: CMSSW_12_1_X_2021-08-02-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/34738/17450/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals-INPUT

• 11601.011601.0_SingleElectronPt10+2021+SingleElectronPt10_pythia8_GenSimINPUT+Digi+Reco+HARVEST+ALCA/step2_SingleElectronPt10+2021+SingleElectronPt10_pythia8_GenSimINPUT+Digi+Reco+HARVEST+ALCA.log
• 11602.011602.0_SingleElectronPt35+2021+SingleElectronPt35_pythia8_GenSimINPUT+Digi+Reco+HARVEST+ALCA/step2_SingleElectronPt35+2021+SingleElectronPt35_pythia8_GenSimINPUT+Digi+Reco+HARVEST+ALCA.log
• 11603.011603.0_SingleElectronPt1000+2021+SingleElectronPt1000_pythia8_GenSimINPUT+Digi+Reco+HARVEST+ALCA/step2_SingleElectronPt1000+2021+SingleElectronPt1000_pythia8_GenSimINPUT+Digi+Reco+HARVEST+ALCA.log

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 48883 differences found in the comparisons
• DQMHistoTests: Total files compared: 39
• DQMHistoTests: Total histograms compared: 2998564
• DQMHistoTests: Total failures: 198381
• DQMHistoTests: Total nulls: 86
• DQMHistoTests: Total successes: 2800075
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.276 KiB( 38 files compared)
• DQMHistoSizes: changed ( 10224.0 ): -0.368 KiB SiStrip/MechanicalView
• DQMHistoSizes: changed ( 250202.181 ): 0.410 KiB SiStrip/MechanicalView
• DQMHistoSizes: changed ( 25202.0 ): 0.234 KiB SiStrip/MechanicalView
• Checked 165 log files, 37 edm output root files, 39 DQM output files
• TriggerResults: found differences in 13 / 38 workflows

+1

@silviodonato, @dpiparo, @qliphy, @perrotta , this fix recover 12_0_0_pre5 HCAL problem.

This pull request is fully signed and it will be integrated in one of the next master IBs (but tests are reportedly failing). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy, @perrotta (and backports should be raised in the release meeting by the corresponding L2)

+1

@bsunanda (or anyone else) please prepare a backport for 12_0_X

merge